[PATCH] D93259: [ELF] Error for out-of-range R_X86_64_[REX_]GOTPCRELX

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 15 00:27:06 PST 2020


grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/test/ELF/x86-64-gotpc-err.s:8
+# CHECK:     error: {{.*}}:(.text+0x9): relocation R_X86_64_REX_GOTPCRELX out of range: 2147483648 is not in [-2147483648, 2147483647]; references data
+# CHECK-NOT: error:
+
----------------
I'd perhaps use `--implicit-check-not=error:` instead. It feels a bit safer because doesn't depend on the order.
Though I don't really think that the order of this error messages might change too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93259/new/

https://reviews.llvm.org/D93259



More information about the llvm-commits mailing list