[PATCH] D93173: [X86] Add test case for commit e52bc1d2bba794b.

Pengfei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 14 18:23:20 PST 2020


pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/test/CodeGen/X86/AMX/amx-intrinsic-chain.ll:12
+; CHECK-NEXT:    movb $1, -{{[0-9]+}}(%rsp)
+; CHECK-NEXT:    movb $16, -{{[0-9]+}}(%rsp)
+; CHECK-NEXT:    movw $64, -{{[0-9]+}}(%rsp)
----------------
LuoYuanke wrote:
> LuoYuanke wrote:
> > pengfei wrote:
> > > Does the adding chain that generates more `__tile1024i` initialization here?
> > > But why do we need to generate more initialization for the same row and col?
> > Adding chain doesn't generate more `__tile1024i` initialization. There 5 movb for row, 5 movw for column and `movb $1, ...` for palette. There are 5 tmm register allocated, so the initialization is correct.
> One of the tilestore is deleted during instruction selection if we don't add chain.
I see. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93173/new/

https://reviews.llvm.org/D93173



More information about the llvm-commits mailing list