[PATCH] D91331: Expand the fp_to_int/int_to_fp/fp_round/fp_extend as libcall for fp128

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:4380
+    std::pair<SDValue, SDValue> Tmp = TLI.makeLibCall(
+        DAG, LC, TLI.getTypeToTransformTo(*DAG.getContext(), RVT), Op,
+        CallOptions, dl, Chain);
----------------
We shouldn't to get call getTypeToTransformTo here. The type is already legal right?


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:4462
+  }
+  case ISD::FP_ROUND: {
+    // X = FP_ROUND(Y, TRUNC)
----------------
Why is STRICT_FP_ROUND handled above and not down here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91331/new/

https://reviews.llvm.org/D91331