[PATCH] D90418: [debuginfo] Vectorizing a loop doesn't terminate all vectorized variable locations

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 26 06:06:36 PST 2020


fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:3701
+  // during the vector operations.
+  if (llvm::PHINode *OldInduction = Legal->getPrimaryInduction()) {
+    LLVM_DEBUG(dbgs() << "LV: Inspecting induction PHI node : " << *OldInduction
----------------
nit: no `llvm::` prefix required.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:3709
+    // All debug users of the now undef induction variable must also be undef
+    for(auto &User: DbgUsers) {
+      LLVM_DEBUG(dbgs() << "LV: Update induction source variable or dependant: "
----------------
Looks like some spaces are missing here. Could you run clang-format on the diff?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90418/new/

https://reviews.llvm.org/D90418



More information about the llvm-commits mailing list