[PATCH] D91433: [SVE][CodeGen] Extend index of masked gathers

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 24 03:28:11 PST 2020


sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:15242
   case ISD::MSCATTER:
-    return performMSCATTERCombine(N, DCI, DAG);
+    return performMaskedGatherScatterCombine(N, DCI, DAG);
   case AArch64ISD::BRCOND:
----------------
It would be good if you can see if such functionality can be moved to SelectionDAGBuilder where some target interface queries if the index needs to be extended. Doing this with a target DAG combine is fine for this patch I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91433/new/

https://reviews.llvm.org/D91433



More information about the llvm-commits mailing list