[PATCH] D91649: [AA] Split up LocationSize::unknown()

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:290
     // first argument.
-    return MemoryLocation(CB->getArgOperand(0), LocationSize::unknown());
+    return MemoryLocation::getAfter(CB->getArgOperand(0));
   return MemoryLocation();
----------------
asbirlea wrote:
> `getBeforeOrAfter`?
If I'm understanding the context here right, this function only deals with accesses for which hasAnalyzableMemoryWrite() returns true, i.e. strcpy, strncpy, strcat and strncat in this branch. These functions don't access memory before the passed pointer.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91649/new/

https://reviews.llvm.org/D91649