[PATCH] D87448: [CodeGen] [WinException] Only produce handler data at the end of the function if needed

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 23 05:19:45 PST 2020


mstorsjo added a comment.

In D87448#2399006 <https://reviews.llvm.org/D87448#2399006>, @hans wrote:

> In D87448#2398082 <https://reviews.llvm.org/D87448#2398082>, @mstorsjo wrote:
>
>> Awesome, thanks! Do you want to have a look at the patch itself and review it, or does @rnk have time? (It's his original suggestion, to emit xdata in .seh_endproc, but the implementation is entirely trivial.)
>
> @rnk knows this stuff much better than I do. Let's see if he has time, otherwise I can try to ramp up on it.

Looks like he hasn't, so @hans, can you give it a read through so I can reland this change?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87448/new/

https://reviews.llvm.org/D87448



More information about the llvm-commits mailing list