[PATCH] D91525: [LoopLoadElim] Make sure all loops are in simplify form. PR48150

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 22 23:40:24 PST 2020


mkazantsev added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopLoadElimination.cpp:627
+    for (Loop *L : depth_first(TopLevelLoop)) {
+      Changed |= simplifyLoop(L, &DT, &LI, SE, AC, /*MSSAU*/ nullptr, false);
       // We only handle inner-most loops.
----------------
aeubanks wrote:
> does every loop need to be simplified? or can the call be moved into the processing of the Worklist below?
We might need any loop in simplified form, and the worklist only contains inner loops.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91525/new/

https://reviews.llvm.org/D91525



More information about the llvm-commits mailing list