[PATCH] D91265: [PowerPC] Don't reuse the address of an illegal typed load for int_to_fp.

Zarko Todorovski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 18 06:38:53 PST 2020


ZarkoCA accepted this revision.
ZarkoCA added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/CodeGen/PowerPC/cvt_i64_to_fp.ll:3
+; RUN:       -mcpu=pwr4 < %s | FileCheck --check-prefix=AIX %s
+; RUN:  llc --verify-machineinstrs -mtriple powerpc-unknown-freebsd \
+; RUN:      -mcpu=pwr4 < %s | FileCheck --check-prefix=SVR4 %s
----------------
Out of curiousity, is there a reason for specifying freebsd vs linux? 


================
Comment at: llvm/test/CodeGen/PowerPC/cvt_i64_to_fp.ll:6
+
+define double @postinctodbl(i64* nocapture %llp) #0 {
+entry:
----------------
nit: I don't think you need the `#0` here. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91265/new/

https://reviews.llvm.org/D91265



More information about the llvm-commits mailing list