[PATCH] D88717: [obj2yaml] [yaml2obj] Add yaml support for SHT_LLVM_BB_ADDR_MAP section.

Rahman Lavaee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 6 12:42:51 PST 2020


rahmanl marked 2 inline comments as done.
rahmanl added a comment.

Thank you @grimar and @jhenderson for the thorough feedback. I will start on llvm-readobj support once I submit this patch.



================
Comment at: llvm/test/tools/yaml2obj/ELF/bb-addr-map.yaml:59
+
+## 1) We can produce a .llvm_bb_addr_map section from a description with section
+##    content.
----------------
jhenderson wrote:
> Trivial nit: to me, the '.' is silent when I say this out loud, so it sounds like "an .llvm_bb_addr_map" would be better than "a .llvm_bb_addr_map". Same applies for point 4). Feel free to ignore.
Fixed here and elsewhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88717/new/

https://reviews.llvm.org/D88717



More information about the llvm-commits mailing list