[compiler-rt] 5cb378f - [sanitizers] Remove the test case involving `new int[0]`

Vy Nguyen via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 5 06:16:57 PST 2020


Author: Vy Nguyen
Date: 2020-11-05T09:16:45-05:00
New Revision: 5cb378fab3bedbaeef708ae725bdccb813d48519

URL: https://github.com/llvm/llvm-project/commit/5cb378fab3bedbaeef708ae725bdccb813d48519
DIFF: https://github.com/llvm/llvm-project/commit/5cb378fab3bedbaeef708ae725bdccb813d48519.diff

LOG: [sanitizers] Remove the test case involving `new int[0]`

Bionic doesn't acutally allocate any memory in this case, so there won't be a leak on Android.

Differential Revision: https://reviews.llvm.org/D90821

Added: 
    

Modified: 
    compiler-rt/test/asan/TestCases/leaks.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/test/asan/TestCases/leaks.cpp b/compiler-rt/test/asan/TestCases/leaks.cpp
index 9c076dd894eb..1207818308c2 100644
--- a/compiler-rt/test/asan/TestCases/leaks.cpp
+++ b/compiler-rt/test/asan/TestCases/leaks.cpp
@@ -14,6 +14,14 @@
 int *t;
 
 __attribute__((noopt)) void leak(int n) {
+#if defined(__ANDROID__) || defined(__BIONIC__)
+  // Bionic does not acutally allocate when n==0, hence
+  // there would not be a leak.
+  // Re-adjust n so the test can pass.
+  if (n == 0)
+    n = 1;
+#endif
+
   // Repeat few times to make sure that at least one pointer is
   // not somewhere on the stack.
   for (int i = 0; i < 10; ++i) {


        


More information about the llvm-commits mailing list