[PATCH] D90612: Start of an llvm.coro.async implementation

John McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 3 11:46:44 PST 2020


rjmccall added a comment.

Looks good to me as a first pass.



================
Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:1883
+          Dom.dominates(CoroBegin, Inst) ||
+          isa<CoroIdAsyncInst>(Inst) /*'fake' use of async context argument*/)
         continue;
----------------
If it makes things easier, you could make the dependency on the context argument implicit, since I think you rely on it being in a particular position anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90612/new/

https://reviews.llvm.org/D90612



More information about the llvm-commits mailing list