[PATCH] D89995: Make the post-commit review expectations more explicit with respect to revert

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 28 11:04:34 PDT 2020


mehdi_amini marked an inline comment as done.
mehdi_amini added inline comments.


================
Comment at: llvm/docs/CodeReview.rst:60-62
+actively in the review. In cases where the patch triggered a hardware-specific
+buildbot failure, a community member with access to hardware similar to that on
+the buildbot that the patch previously caused to fail.
----------------
nhaehnle wrote:
> This sentence is missing a verb. Maybe something along the lines of: "In cases where the problem is identified by a buildbot, a community member with access to hardware similar to that on the buildbot is excepted to engage in the review."
Applied the suggestion as-is, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89995/new/

https://reviews.llvm.org/D89995



More information about the llvm-commits mailing list