[PATCH] D87832: [IndVars] Remove monotonic checks with unknown exit count

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 28 04:39:03 PDT 2020


mkazantsev added a comment.

The failure doesn't reproruce and looks related to this story:

  commit 2a4e704c92e8ec3d9217a7333368ea53cf3a583f
  Author: Nico Weber <thakis at chromium.org>
  Date:   Tue Oct 27 09:18:42 2020 -0400
  
      Revert "Use uint64_t for branch weights instead of uint32_t"
  
      This reverts commit e5766f25c62c185632e3a75bf45b313eadab774b.
      Makes clang assert when building Chromium, see https://crbug.com/1142813
      for a repro.
  
  commit e5766f25c62c185632e3a75bf45b313eadab774b
  Author: Arthur Eubanks <aeubanks at google.com>
  Date:   Wed Sep 30 12:11:46 2020 -0700
  
      Use uint64_t for branch weights instead of uint32_t
  
      CallInst::updateProfWeight() creates branch_weights with i64 instead of i32.
      To be more consistent everywhere and remove lots of casts from uint64_t
      to uint32_t, use i64 for branch_weights.
  
      Reviewed By: davidxl
  
      Differential Revision: https://reviews.llvm.org/D88609

I am returning the change as the revert was erroneous.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87832/new/

https://reviews.llvm.org/D87832



More information about the llvm-commits mailing list