[PATCH] D89105: [X86] Support Intel avxvnni

Pengfei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 25 20:04:43 PDT 2020


pengfei added inline comments.


================
Comment at: clang/test/Preprocessor/predefined-arch-macros.c:1637
 
 // RUN: %clang -march=sapphirerapids -m32 -E -dM %s -o - 2>&1 \
 // RUN:     -target i386-unknown-linux \
----------------
You need to add to sapphirerapids too.


================
Comment at: clang/test/Preprocessor/predefined-arch-macros.c:1707
 
 // RUN: %clang -march=sapphirerapids -m64 -E -dM %s -o - 2>&1 \
 // RUN:     -target i386-unknown-linux \
----------------
You need to add to sapphirerapids too.


================
Comment at: llvm/docs/ReleaseNotes.rst:124
 * Support for ``UINTR`` instructions has been added.
+* Support for ``AVXVNNI`` instructions has been added.
 
----------------
You also need to add it to Clang release notes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89105/new/

https://reviews.llvm.org/D89105



More information about the llvm-commits mailing list