[PATCH] D90124: [SLP] Pass VecPred argument to getCmpSelInstrCost.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:3560
+             !match(V, MatchCmp)) ||
+            (!First && VecPred == CurrentPred)) {
+          VecPred = CmpInst::BAD_ICMP_PREDICATE;
----------------
dmgreen wrote:
> This doesn't set First to false, and should the == be !=?
Whops, looks like I did not adjust that after initially moving some code around :( Should be fixed now. I am not sure if there's a way we can currently exercise this with a test, because I am not sure if we ever vectorize compares that do have different conditions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90124/new/

https://reviews.llvm.org/D90124