[PATCH] D90124: [SLP] Pass VecPred argument to getCmpSelInstrCost.

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 25 14:17:50 PDT 2020


dmgreen added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:3560
+             !match(V, MatchCmp)) ||
+            (!First && VecPred == CurrentPred)) {
+          VecPred = CmpInst::BAD_ICMP_PREDICATE;
----------------
This doesn't set First to false, and should the == be !=?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90124/new/

https://reviews.llvm.org/D90124



More information about the llvm-commits mailing list