[PATCH] D89178: [X86] Alternate implementation of D88194.

Xiang Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 24 23:36:39 PDT 2020


xiangzhangllvm added a comment.

In D89178#2352272 <https://reviews.llvm.org/D89178#2352272>, @craig.topper wrote:

> Are we ok with this implementation?
>
> I don't have a great way to protect intrinsics not using TargetConstant properly in the future, but I think we're ok at the moment based on what I see in the isel table.

LGTM, if problem in the future, I'll fix it. Tkx !!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89178/new/

https://reviews.llvm.org/D89178



More information about the llvm-commits mailing list