[PATCH] D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format

[Yusra Syeda via Phabricator via llvm-commits]

yusra.syeda marked 2 inline comments as done.
yusra.syeda added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/GOFF.h:173-174
+
+// RLDRelocationType is internal use only and these values not put
+// in GOFF format
+enum RLDRelocationType {
----------------
jhenderson wrote:
> I'm not quite sure what this comment is saying. When it says "internal use only" do you mean not defined in any spec, and used only as a helper within the format processing? If so, the enum values should be styled after LLVM coding standard i.e. "UpperCamelCase". If not, you need to clarify what is meant by "internal use only".
This is used only as a helper, but is not needed in this patch. It has been removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89071/new/

https://reviews.llvm.org/D89071