[PATCH] D89432: [llvm-elfabi] Emit ELF .dynsym and .dynamic sections

[Fangrui Song via Phabricator via llvm-commits]

MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.

There appears to multiple review comments from @mcgrathr so I think "Request Changes" is the suitable action for now.



================
Comment at: llvm/lib/InterfaceStub/ELFObjHandler.cpp:131
+    // TODO: Implement a address generator.
+    S.st_value = 0;
+    S.st_size = StSize;
----------------
Remove the TODO. 0 is safe.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89432/new/

https://reviews.llvm.org/D89432