[PATCH] D90008: [NFC] Use [MC]Register in RegAllocPBQP & RegisterCoalescer
Mircea Trofin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 23 08:14:38 PDT 2020
mtrofin accepted this revision.
mtrofin added a comment.
This revision is now accepted and ready to land.
lgtm, some nits.
================
Comment at: llvm/include/llvm/CodeGen/RegAllocPBQP.h:261
std::unique_ptr<unsigned[]> OptUnsafeEdges;
- unsigned VReg = 0;
+ Register VReg = 0;
GraphMetadata::AllowedRegVecRef AllowedRegs;
----------------
Nit: can drop the init here, because Register has a ctor.
================
Comment at: llvm/include/llvm/MC/MCRegister.h:24
+ friend hash_code hash_value(const MCRegister &);
+
unsigned Reg;
----------------
Remove new line here (unrelated change?)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90008/new/
https://reviews.llvm.org/D90008
More information about the llvm-commits
mailing list