[PATCH] D89969: [SLP] Consider alternatives for cost of select instructions.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 23 08:01:01 PDT 2020


fhahn updated this revision to Diff 300295.
fhahn added a comment.

Updated to move matching code to ValueTracking where the other related match code lives.

In D89969#2349241 <https://reviews.llvm.org/D89969#2349241>, @RKSimon wrote:

> Why the reluctance to actually generate the min/max intrinsics?

Nothing other than trying to keep the patch as small as possible. If people think it's better to generate the intrinsics directly, I can adjust SLP codegen.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89969/new/

https://reviews.llvm.org/D89969

Files:
  llvm/include/llvm/Analysis/ValueTracking.h
  llvm/lib/Analysis/ValueTracking.cpp
  llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
  llvm/test/Transforms/SLPVectorizer/AArch64/vectorizable-selects-min-max.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89969.300295.patch
Type: text/x-patch
Size: 50970 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201023/7b171d53/attachment.bin>


More information about the llvm-commits mailing list