[PATCH] D87705: [PowerPC] Implement Set Boolean Condition Instructions

[Lei Huang via Phabricator via llvm-commits]

lei accepted this revision.
lei added a comment.
This revision is now accepted and ready to land.

LGTM.  Thanks for the update.
Please address the additional comments on commit.



================
Comment at: llvm/test/CodeGen/PowerPC/p10-setbc-ri.ll:438
+define signext i32 @setbc27(i64 %a) {
+; CHECK-P10-LABEL: setbc27:
+; CHECK-P10:       # %bb.0: # %entry
----------------
no such label...


================
Comment at: llvm/test/CodeGen/PowerPC/testComparesi32gtu.ll:25
+; RUN:   --implicit-check-not cmpw --implicit-check-not cmpd \
+; RUN:   --implicit-check-not cmpl
 
----------------
I think the implicit checks here need to be diff for pwr10.  From what I can see... instead of `cmpw`, on p10 it generates `cmplw`.  So shouldn't we be using that as the implicity check value?


================
Comment at: llvm/test/CodeGen/PowerPC/testComparesi32leu.ll:21
+; RUN:   FileCheck %s --check-prefix=CHECK-P10-CMP --implicit-check-not cmpw \
+; RUN:   --implicit-check-not cmpd --implicit-check-not cmpl
 
----------------
same comment for implicit checks.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87705/new/

https://reviews.llvm.org/D87705