[PATCH] D88891: [DebugInfo][InstrRef][1/4] Support transformations that widen or narrow defined values

Fri Oct 23 04:42:08 PDT 2020

jmorse added a comment.

Sorry it took so long to get back to this,

In D88891#2323663 <https://reviews.llvm.org/D88891#2323663>, @MaskRay wrote:

> `curl -L 'https://reviews.llvm.org/D88891?download=1'` does not have a/ or b/ prefix. Can you upload a diff with either `arc diff`, `git format-patch -1` or `git diff 'HEAD^'`? Thanks.
>
> I think `arc diff` and `git format-patch -1` are preferred because they have the base commit information so people can apply this locally with `arc patch D88891`.

Hmmm -- I did not know there was that much base / parent information preserved in phab, looking closer I see that other peoples revisions have hashes and parents, wheras mine only have diff numbers. I'll try uploading the output of `git-format-patch` and see what happens; I've also updated the parent commits to better represent what order these patches need to apply in.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88891/new/

https://reviews.llvm.org/D88891