[PATCH] D90019: [yaml2obj] - Add a way to override the sh_addralign field of a section.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/override-shaddralign.yaml:4-9
+## Demonstrate that we can't simply use the "AddressAlign" key,
+## because the output produced is too large.
+
+# RUN: not yaml2obj %s -DKEY="AddressAlign" 2>&1 | FileCheck %s --check-prefix=ERR
+
+# ERR: error: the desired output size is greater than permitted. Use the --max-size option to change the limit
----------------
I'm not sure we need to do this. Showing that the output offset matches what you'd expect due to the AddressAlign field and not the ShAddrAlign field would be better.


================
Comment at: llvm/test/tools/yaml2obj/ELF/override-shaddralign.yaml:39-41
+  - Name:    .dynsym
+    Type:    SHT_DYNSYM
+    [[KEY]]: 0x1111111111111111
----------------
I don't understand why we need multiple different kinds of sections. This is generic behaviour, so doesn't need testing with everything, right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90019/new/

https://reviews.llvm.org/D90019