[PATCH] D88983: [NFCI] Replace AArch64StackOffset by StackOffset.

[David Sherwood via Phabricator via llvm-commits]

david-arm added a comment.

One suggestion for a possible fold of some additions, but otherwise looks good to me!



================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:1944
         -AFI->getCalleeSaveBaseToFrameRecordOffset();
-    StackOffset FPOffset = StackOffset(OffsetFromFPToSVEArea, MVT::i8) +
-                           StackOffset(ObjectOffset, MVT::nxv1i8);
+    StackOffset FPOffset = StackOffset::getFixed(OffsetFromFPToSVEArea) +
+                           StackOffset::getScalable(ObjectOffset);
----------------
It's just a thought, but in cases such as this where we're initialising to a composite we could replace the addition with:

StackOffset::get(OffsetFromFPToSVEArea, ObjectOffset)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88983/new/

https://reviews.llvm.org/D88983