[PATCH] D89969: [SLP] Consider alternatives for cost of select instructions.

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 23 00:15:50 PDT 2020


samparker added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:3378
+// return the cost for that variant.
+static int getVectorMinMaxCost(ArrayRef<Value *> VL, Type *VecTy, Type *MaskTy,
+                               TTI::TargetCostKind CostKind,
----------------
Maybe this should be part of TTI? There's already static methods for reduction matching and could this logic not also be useful for the loop vectorizer?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89969/new/

https://reviews.llvm.org/D89969



More information about the llvm-commits mailing list