[PATCH] D89921: [LLD] [COFF] Align all debug directories

Thu Oct 22 20:31:40 PDT 2020

penzn marked an inline comment as done.
penzn added inline comments.

================
Comment at: lld/COFF/Writer.cpp:951
   if (config->debug || config->repro || config->cetCompat) {
     debugDirectory = make<DebugDirectoryChunk>(debugRecords, config->repro);
     debugInfoSec->addChunk(debugDirectory);
----------------
penzn wrote:
> rnk wrote:
> > Can we make the DebugDirectoryChunk set the default alignment to 4 instead? I believe other chunks do that as well.
> Let me try that.
On the other hand, do you mean NonSectionChunk? DebugDirectoryChunk and the debug directory sections (CV, ExtendedDllChars) all derive from it. Also, the alignment here was added in D70606.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89921/new/

https://reviews.llvm.org/D89921