[PATCH] D89892: [AsmPrinter] Add per BB instruction mix remark.

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg accepted this revision.
thegameg added a comment.

This looks great! Thanks!

If this evolves into something bigger (e.g. per-loop instruction mix remarks, instruction mix in assembly comments, etc.) it may be useful to have it around as an analysis.



================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1125
     // Get MachineLoopInfo or compute it on the fly if it's unavailable
     MLI = getAnalysisIfAvailable<MachineLoopInfo>();
     if (!MLI) {
----------------
Looks like we can have loop info around here too, maybe a nice future extension would be to emit a remark with the instruction mix per loop too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89892/new/

https://reviews.llvm.org/D89892