[PATCH] D89954: [SCEV][NFC] Cache symbolic max exit count

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 22 13:09:12 PDT 2020


nikic accepted this revision.
nikic added a comment.

LGTM as well.



================
Comment at: llvm/include/llvm/Analysis/ScalarEvolution.h:747
     ConstantMaximum,
+    /// A constant which provides an upper bound on the exact trip count.
+    SymbolicMaximum,
----------------
Nit: This comment needs adjustment for constant -> symbolic.


================
Comment at: llvm/include/llvm/Analysis/ScalarEvolution.h:1341
 
     /// \name Helper projection functions on \c ConstantMaxAndComplete.
     /// @{
----------------
Nit: The mention of ConstantMaxAndComplete is stale.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89954/new/

https://reviews.llvm.org/D89954



More information about the llvm-commits mailing list