[PATCH] D89889: [test] Simplify pr33641_remove_arg_dbgvalue.ll

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

> The legacy PM pass ran passes on SCCs in a different order, causing
> argpromotion to not trigger on @bar().

I see, so DSE would run, then bar would become unreferenced, and then there would be no reason to promote arguments?



================
Comment at: llvm/test/Transforms/ArgumentPromotion/pr33641_remove_arg_dbgvalue.ll:23
-define internal void @bar(%p_t %p)  {
-; CHECK-LABEL: define {{[^@]+}}@bar()
-; CHECK-NEXT:    call void @llvm.dbg.value(metadata i16* undef, metadata !3, metadata !DIExpression()), !dbg !5
----------------
I think it's generally good practice to keep around some CHECK lines for context, like this `define @bar` line. It helps to make the test more robust to future modifications that add code later with more dbg.values that might match this CHECK here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89889/new/

https://reviews.llvm.org/D89889