[PATCH] D89823: [AArch64][GlobalISel] Move imm adjustment for G_ICMP to post-legalizer lowering

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 22 11:34:45 PDT 2020


paquette updated this revision to Diff 300057.
paquette added a comment.

- Remove leftover debug code
- Make the test also show that we select the right thing
- Improve a couple comments
- Add G_SELECT testcase showing that still works
- Add ands/tst testcase showing we can now fold constants into the tst/ands case


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89823/new/

https://reviews.llvm.org/D89823

Files:
  llvm/lib/Target/AArch64/AArch64Combine.td
  llvm/lib/Target/AArch64/GISel/AArch64GlobalISelUtils.h
  llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp
  llvm/lib/Target/AArch64/GISel/AArch64PostLegalizerLowering.cpp
  llvm/test/CodeGen/AArch64/GlobalISel/fold-select.mir
  llvm/test/CodeGen/AArch64/GlobalISel/postlegalizer-lowering-adjust-icmp-imm.mir
  llvm/test/CodeGen/AArch64/GlobalISel/select-arith-immed-compare.mir
  llvm/test/CodeGen/AArch64/GlobalISel/select-cbz.mir
  llvm/test/CodeGen/AArch64/GlobalISel/tbz-sgt.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89823.300057.patch
Type: text/x-patch
Size: 70735 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201022/dc0c95cb/attachment.bin>


More information about the llvm-commits mailing list