[PATCH] D87326: [ADT] Fix reference invalidation when self referencing a SmallVector

Thu Oct 22 09:56:36 PDT 2020

nikic added a comment.

Here's the numbers I see with the current version of the patch:

Instructions: https://llvm-compile-time-tracker.com/compare.php?from=4b7dafd9046f0ceaadacaafe0ea4a1fb00cf70a5&to=24b013b651f8f204f633d2edffa0baa7b121e21b&stat=instructions 1.26% regression at `O3`, 1.72% at `O0-g`
Max-rss: https://llvm-compile-time-tracker.com/compare.php?from=4b7dafd9046f0ceaadacaafe0ea4a1fb00cf70a5&to=24b013b651f8f204f633d2edffa0baa7b121e21b&stat=max-rss 1.64% regression at `O3`, 3.55% at `O0-g`
Clang binary size: 82132053 to 82490366 which is an 0.4% increase

Peculiarly, even though the increase in clang binary size is indeed greatly mitigated (0.4%, where the last version had a 6.5% increase), the impact on max-rss does not seem mitigated. Maybe my assumption that the max-rss increase is caused entirely by the binary size increase was not correct.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87326/new/

https://reviews.llvm.org/D87326