[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

Erich Keane via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 22 09:45:31 PDT 2020


erichkeane added a comment.

In D88645#2347725 <https://reviews.llvm.org/D88645#2347725>, @Tyker wrote:

> In D88645#2347050 <https://reviews.llvm.org/D88645#2347050>, @aaron.ballman wrote:
>
>> LGTM aside from a request for a comment to be added. Thank you!
>
> do you mean an RFC on llvm-dev/cfe-dev ?

He means this review comment he made requesting a comment in the code: >Ah, thank you for explaining that! Can you add a comment to the code to make that clear for others who may run across it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88645/new/

https://reviews.llvm.org/D88645



More information about the llvm-commits mailing list