[PATCH] D89162: [SVE] Lower fixed length VECREDUCE_SEQ_FADD operation

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added a comment.

Sorry @cameron.mcinally I've not had much time for code reviews this week although will take proper look tomorrow.  I have a question though.  You've added extra legalisation support but I don't see any explicit tests (or at least ones with matching check lines) for it.  Is this something you need for this patch? (I'm guessing sve-fixed-length-fp-reduce.ll's stock NEON run line triggers the cases?) If so then there really should be a neon specific test file that verifies the widening and scalarisation changes as the NEON run line for the "fixed-length" tests is more about ensuring no SVE instructions slip through.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89162/new/

https://reviews.llvm.org/D89162