[PATCH] D89038: [PatternMatch] Add new FP matchers. NFC.

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/include/llvm/IR/PatternMatch.h:616
+/// Match a finite FP constant, i.e. not infinity or NaN.
+/// For vectors, this includes constants with undefined elements.
+inline cstfp_pred_ty<is_finite> m_Finite() {
----------------
lebedev.ri wrote:
> foad wrote:
> > lebedev.ri wrote:
> > > foad wrote:
> > > > lebedev.ri wrote:
> > > > > So if this is using `apf_pred_ty`, then this doesn't support `undef` constants then?
> > > > Correct. m_Finite() does, m_Finite(const APFloat *&) does not. This is the pre-existing problem I mentioned which has now been copied across from the integer matchers to the fp ones.
> > > But it says it does.
> > Yes, that's the pre-existing bug! Anyway I have now fixed this for the new float matchers, but I have not touched the existing integer matchers.
> Okay, you lost me there.
> How it's a "pre-existing bug", if you add this matcher here?
I should have said: a pre-existing bug in the integer matchers, which I copied across to the new fp matchers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89038/new/

https://reviews.llvm.org/D89038