[PATCH] D89038: [PatternMatch] Add new FP matchers. NFC.

Thu Oct 22 08:18:12 PDT 2020

foad added a comment.

In D89038#2347410 <https://reviews.llvm.org/D89038#2347410>, @lebedev.ri wrote:

> I'm lost.
> If their code related to handling splats is identical (neither of them pass anything into `getSplatValue()`), why do they end up with different `undef` behaviour?

cstfp_pred_ty has its own handling of non-splat vector constants. apf_pred_ty does not. I realise this is not great! It was copied directly from the integer equivalents, which have the same inconsistency.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89038/new/

https://reviews.llvm.org/D89038