[PATCH] D89038: [PatternMatch] Add new FP matchers. NFC.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/include/llvm/IR/PatternMatch.h:587
+/// Match a non-NaN FP constant.
+/// For vectors, this includes constants with undefined elements.
+inline cstfp_pred_ty<is_nonnan> m_NonNaN() {
----------------
lebedev.ri wrote:
> lebedev.ri wrote:
> > I think i'd like to see some dedicated tests with `undef`s in `llvm/unittest/IR/PatternMatch.cpp`.
> So does it or does it not allow undefs?
AFAICT cstfp_pred_ty supports vectors with undef elements but apf_pred_ty doesnot


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89038/new/

https://reviews.llvm.org/D89038