[PATCH] D89337: [DebugInfo][Docs] Document MIR language debug-info constructs

Thu Oct 22 05:32:22 PDT 2020

jmorse marked 4 inline comments as done.
jmorse added inline comments.

================
Comment at: llvm/docs/MIRLangRef.rst:797
+
+Most of the debugging information in a MIR file is to be found in the metadata
+of the embedded module. Within a machine function, that metadata is referred to
----------------
MaskRay wrote:
> aprantl wrote:
> > `debug information` is a more common term I think
> Both GCC documentation and DWARF specifications refer to this term as "debugging information". There are many places using "debug information" as well. I think perhaps "debugging information" is indeed more formal and using it here may be fine. 
I've no strong opinion on the wording; alright to leave it as it is?

================
Comment at: llvm/docs/MIRLangRef.rst:801
+
+Source Locations
+^^^^^^^^^^^^^^^^
----------------
aprantl wrote:
> Can you unify all headlines to use the same capitalization rules?
Have rewritten "locations" to be lower case

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89337/new/

https://reviews.llvm.org/D89337