[PATCH] D72939: [Schedule] Add a MultiHazardRecognizer

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 22 05:16:20 PDT 2020


SjoerdMeijer added a comment.

Hazard recognisers is not really my area, but this looks like a straightforward refactoring to me. Two nits: one is a style issue inlined, the other is just a quick question if you plan to use this extra flexibility any time soon?



================
Comment at: llvm/lib/CodeGen/MultiHazardRecognizer.cpp:22
+MultiHazardRecognizer::~MultiHazardRecognizer() {
+  for (auto R : Recognizers) {
+    delete R;
----------------
No need for the curly brackets. Same for all the other loops below.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72939/new/

https://reviews.llvm.org/D72939



More information about the llvm-commits mailing list