[PATCH] D89693: [AArch64] Favor post-increments

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

Those numbers don't look too bad, but like you say it's probably worth looking into what x264_r is doing, just to see what is going on. Sanne ran some other numbers from the burst compiler and they were about the same - some small improvements, a couple of small losses but overall OK. That gives us confidence that big out of order cores are not going to hate this.

The original tests were on an in-order core I believe? Which from the optimization guide looks like it should be sensible to use. And the option doesn't seem to be messing anything up especially.

Can you add a test for vector postincs, the kind of thing that you would get in a loop? I only see changes for scalars here.



================
Comment at: llvm/test/CodeGen/AArch64/shrink-wrapping-vla.ll:91
 ; CHECK: mov [[SAVE:x[0-9]+]], sp
-; CHECK: sub [[X2]], [[X2]], [[X1]]
+; CHECK: sub [[X3]], [[X3]], [[X2]]
 
----------------
How is this test changing? Just the initial operand for the add?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89693/new/

https://reviews.llvm.org/D89693