[PATCH] D89830: [ValuteTracking] Handle alignment assume bundles

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 21 16:11:11 PDT 2020


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM "but" already "fixed" in D88669 <https://reviews.llvm.org/D88669>. we need to merge one of the two, they basically do the same thing. We should make sure to merge all tests ;)



================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:1965
     Align Alignment = V->getPointerAlignment(Q.DL);
-    Known.Zero.setLowBits(countTrailingZeros(Alignment.value()));
+    Known.Zero.setLowBits(Log2(Alignment));
   }
----------------
Unrelated but LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89830/new/

https://reviews.llvm.org/D89830



More information about the llvm-commits mailing list