[PATCH] D89820: [AArch64][GlobalISel] Split post-legalizer combiner to allow for lowering at -O0

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 21 14:39:48 PDT 2020


paquette added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64.h:63
 FunctionPass *createAArch64PostLegalizeCombiner(bool IsOptNone);
+FunctionPass *createAArch64PostLegalizeLowering(bool IsOptNone);
 FunctionPass *createAArch64StackTaggingPass(bool IsOptNone);
----------------
aemerson wrote:
> Not sure why the create functions use a verb instead of the noun, we should keep it consistent.
I'm going to guess that someone forgot to type the 's' one day and now we have to live with the typo.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89820/new/

https://reviews.llvm.org/D89820



More information about the llvm-commits mailing list