[PATCH] D88861: GC-parseable element atomic memcpy/memmove

Artur Pilipenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 21 11:29:41 PDT 2020


apilipenko added inline comments.


================
Comment at: llvm/docs/LangRef.rst:20257
 lowered to a call to the symbol ``__llvm_memcpy_element_unordered_atomic_*``. Where '*'
-is replaced with an actual element size.
+is replaced with an actual element size. See see :ref:`RewriteStatepointsForGC intrinsic
+lowering <RewriteStatepointsForGC_intrinsic_lowering>` for details on GC specific
----------------
skatkov wrote:
> See see?
Fixed.


================
Comment at: llvm/docs/LangRef.rst:20336
 ``__llvm_memmove_element_unordered_atomic_*``. Where '*' is replaced with an
 actual element size.
 
----------------
skatkov wrote:
> The same link as for memcpy?
Fixed.


================
Comment at: llvm/docs/Statepoints.rst:836
+take a safepoint. Otherwise, the call is made GC parseable by wrapping the
+call into a statepoint. This makes is possible to take a safepoint during
+copy operation. Note that a GC parseable copy operation is not required to
----------------
skatkov wrote:
> "This makes it is possible"?
Fixed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88861/new/

https://reviews.llvm.org/D88861



More information about the llvm-commits mailing list