[PATCH] D88827: [llvm-objcopy][NFC] Move core implementation of llvm-objcopy into separate library.

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 21 09:19:08 PDT 2020


sbc100 added a comment.

In D88827#2344900 <https://reviews.llvm.org/D88827#2344900>, @echristo wrote:

> I really do think this needs to be under object. It can be separate in there as lib/Object/Copy if you want, but I don't think it should be a parallel directory. Hopefully the updates for the move aren't overly onerous here.
>
> -eric

Won't that mean that any tool that just wants to read in object files (e.g. lld) will need to build this extra code for no reason?  Not a huge deal I guess (especially for lld which due to LTO pulls in all of llvm!) but I imagine there are many tools that just want to read (and not modify) objects.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88827/new/

https://reviews.llvm.org/D88827



More information about the llvm-commits mailing list