[PATCH] D89831: [AArch64][SVE] Fix umin/umax lowering to handle out of range imm.

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 21 09:01:45 PDT 2020


sdesmalen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp:3146
+    case MVT::i16:
+      ImmVal &= 0xFFFF;
+      break;
----------------
Maybe I'm missing something obvious, but I don't see why any masking is needed.
Is removing `ImmVal = ImmVal & 0xFF;` not sufficient?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89831/new/

https://reviews.llvm.org/D89831



More information about the llvm-commits mailing list