[PATCH] D89891: [llvm-ar][Object] Fix detection of need for 64-bit archive symbol tables

[Andrew Ng via Phabricator via llvm-commits]

andrewng created this revision.
andrewng added reviewers: MaskRay, grimar, jakehehrlich, jyknight.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.
andrewng requested review of this revision.

The code to detect the requirement for 64-bit offsets in the archive
symbol table was not correctly accounting for the size of all the
contents of the symbol table itself, e.g. the symbol table's header and
string table. Also was not considering the variation in symbol table
formats. This could result in the creation of large archives with a
corrupt symbol table.


https://reviews.llvm.org/D89891

Files:
  llvm/lib/Object/ArchiveWriter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89891.299707.patch
Type: text/x-patch
Size: 4399 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201021/69c4f829/attachment.bin>