[PATCH] D89665: [LSR] ignore profitable chain optimization when instruction number is the major cost

[ChenZheng via Phabricator via llvm-commits]

shchenz added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp:2841
+  // example instruction number.
+  if (!TTI.isRegisterNumberMajorCost())
+    return false;
----------------
samparker wrote:
> This can potentially interfere with the calls to isProfitableLSRChainElement, which also isn't specifically interested in register uses. It will require more cycles to process but how about moving this to after the for loop below?
good catch. Updated


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89665/new/

https://reviews.llvm.org/D89665