[PATCH] D89451: [SystemZ] Mark unsaved argument R6 as live throughout function

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 21 05:18:34 PDT 2020


uweigand accepted this revision.
uweigand added a comment.
This revision is now accepted and ready to land.

See inline comment; otherwise this LGTM.



================
Comment at: llvm/lib/Target/SystemZ/SystemZFrameLowering.cpp:357
+    use_iterator E = MRI->use_nodbg_end();
+    for (use_iterator I = MRI->use_nodbg_begin(SystemZ::R6D); I != E; ++I)
+      I->setIsKill(false);
----------------
Just a minor nit, maybe the loop can be written more compact using C++11 features like:

```
    for (auto &I : MRI->use_nodbg_operands(SystemZ::R6D))

```
This should be equivalent as far as I can see.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89451/new/

https://reviews.llvm.org/D89451



More information about the llvm-commits mailing list