[PATCH] D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder.

[Chih-Ping Chen via Phabricator via llvm-commits]

cchen15 added a comment.

Regarding test: Does the test idea laid out in my opening comment sound reasonable?



================
Comment at: llvm/include/llvm/IR/DIBuilder.h:502
+                                     DIType *Ty, DINodeArray Subscripts,
+                                     Metadata *DataLocation = nullptr,
+                                     Metadata *Associated = nullptr,
----------------
aprantl wrote:
> Can these be any more specific DINode types?
These can be DIExpression, ConstantAsMetadata, etc, so Metadata looks to be the right specificity (and the underlying 'get' function it calls types them as Metadata too).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89817/new/

https://reviews.llvm.org/D89817